add support for units and handle mindim=None correctly.

mathandy / svgpathtools

A collection of tools for manipulating and analyzing SVG Path objects and Bezier curves.

MIT License

557 stars 142 forks source link

add support for units and handle mindim=None correctly. #149

Closed njhurst closed 3 years ago

njhurst commented 3 years ago

This PR adds support for real-world units in generated svg files (useful for generating CNC inputs, for example). It also fixes a bug where mindim=None crashes, rather than unconstraining the viewport size as you would expect.

mathandy commented 3 years ago

Thanks @njhurst this looks good. One request though, please move the new argument baseunit to be the last argument taken in. That way we won't mess up anyone's positional arguments when I merge this.

mathandy commented 3 years ago

Thanks @njhurst !