search

mathandy / svgpathtools

A collection of tools for manipulating and analyzing SVG Path objects and Bezier curves.
MIT License
558 stars 142 forks source link

relative path support #81

Closed taoari closed 4 years ago

mathandy commented 6 years ago

Hey @taoari, this looks pretty good, thanks for your contribution! All new features must come with unittests though -- this is stated in the contributor guidelines.

taoari commented 6 years ago

@mathandy The unit test is added. I planned to add the test case in test_path.py. But it seems that a lot of tests can not pass. So I created a new file test_path_d.py.

mathandy commented 6 years ago

Hey @taoari -- yeah, there's one test that currently doesn't pass, which is my fault. Hopefully that will be fixed soon (my guess is the test answer is actually wrong, but I'm not sure yet). Please add your test to test_path.py.

On Sat, Nov 17, 2018 at 7:18 PM taoari notifications@github.com wrote:

@mathandy https://github.com/mathandy The unit test is added. I planned to add the test case in test_path.py. But it seems that a lot of tests can not pass. So I created a new file test_path_d.py.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mathandy/svgpathtools/pull/81#issuecomment-439664535, or mute the thread https://github.com/notifications/unsubscribe-auth/ADB0PVPs4pF2-dhfFmmCQ14vwmImO8jsks5uwNFugaJpZM4YnTlo .

taoari commented 6 years ago

@mathandy Done!

taoari commented 6 years ago

@mathandy FYI, the test answer is not wrong, it is just half circle: pi*50^2/2. May be the code is wrong.