mathanmahe / pe

0 stars 0 forks source link

Half baked duplicate detection for add satisfaction #3

Open mathanmahe opened 2 years ago

mathanmahe commented 2 years ago

image.png

Entered an extra space in a user's name and duplication detection, which otherwise works, does not work in this case. This is a feature flaw as per the module website, as there were no warnings or error messages for this scenario.

nus-se-script commented 2 years ago

Team's Response

Efforts were made to detect if the name of the customer added is the same. Hence, it should not be graded as a medium bug.

image.png

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Half baked duplicate detection for add housekeeper

image.png

The duplicate detection which otherwise works does not detect if the user has inputted an extra space between names.

Therefore this would be a feature flaw as per the module website.


[original: nus-cs2113-AY2122S2/pe-interim#128] [original labels: type.FeatureFlaw severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Efforts were made to detect if the name of the person added is the same. Hence, it should not be marked as a medium bug.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: This bug is across various sections of the program so essentially it is the same bug on two different features.

Perhaps they should be counted as separate bugs instead.


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]