mathause / filefinder

find and parse file and folder names
MIT License
3 stars 1 forks source link

add on_parse_error behaviour #75

Closed veni-vidi-vici-dormivi closed 7 months ago

veni-vidi-vici-dormivi commented 8 months ago

Closes #60

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (09d212b) 88.05% compared to head (3c844d6) 87.76%. Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #75 +/- ## ========================================== - Coverage 88.05% 87.76% -0.29% ========================================== Files 5 5 Lines 268 278 +10 ========================================== + Hits 236 244 +8 - Misses 32 34 +2 ``` | [Flag](https://app.codecov.io/gh/mathause/filefinder/pull/75/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mathias+Hauser) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/mathause/filefinder/pull/75/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mathias+Hauser) | `87.76% <100.00%> (-0.29%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mathias+Hauser#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

veni-vidi-vici-dormivi commented 8 months ago

Last thing that we could do is to implement that on_parse_error can only be one of raise, warn, skip. At the moment anything other evokes the same behavior as skip. I think this is the same as in on_missing here https://github.com/mathause/filefinder/blob/main/filefinder/filters.py.

veni-vidi-vici-dormivi commented 7 months ago

@mathause good like this? :)

mathause commented 7 months ago

Thanks :blush: