Closed veni-vidi-vici-dormivi closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.85%. Comparing base (
09d212b
) to head (83dc9c7
). Report is 9 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The check for the correct keyword is often done outside the inner if to fail early
Of course, that makes sense. Would you still put it in the function where it is actually used or in the wrapper?
Would you still put it in the function where it is actually used or in the wrapper?
Here, I would put it in priority_filter
(however, I don't want to generalize. If _prioritize
was used in several places its prob. better to put it there)
Actually in on_parse_error the options are 'raise', 'warn' and 'skip'. I guess we should change 'error' to 'raise' here too? 😅
Actually in on_parse_error the options are 'raise', 'warn' and 'skip'. I guess we should change 'error' to 'raise' here too? 😅
Good catch. I quickly had a look (in xarray) and "raise"
seems the default choice.
(I also found that they rather use "ignore"
instead of "skip"
, so I am considering if we really should ~not rather~ use "skip"
here)
Well well well then let's go back to ignore and change error to raise. Also, I'll open another branch for the analogous parse_error redo.
But for parse_error skip -> ignore we don't need a FutureWarning because we didn't release it yet, is that right?
Can you merge main into this PR? Maybe you'll get a merge conflict :rocket:
Closes #77 Change option "ignore" to "skip" in on_missing to be consistent with on_parse_error (see #75). Implement behavior if on_missing is none of the implemented options.