search

mathcodes / contentfordevelopers

We aim to please users with not just another solution bank to leetcode problems, but more. Contributors are encouraged to upload and share any additional content such as visual diagrams, animated GIFs, notes, charts, or whatever they use to not only solve, but UNDERSTAND the problem at hand.
https://www.contentfordevelopers.com/
MIT License
33 stars 31 forks source link

Feat footer #122

Closed jackz070 closed 1 year ago

jackz070 commented 1 year ago

In commit 82657f980fc520faf689f6804b6d1e7999838c66 I've implemented a footer, the basic idea is shown there, it needs some cleanup and small improvements. I've focused on layout, not style, as style will have to follow the style guidelines once we have some. Submitting it seems to be the easiest way to display it for discussion, hope that's okay.

Also adding commit 87339c5f85974e6157e083954170eee3894e4889 - remove footer class from unrelated CSS files. I've just noticed it has more changes than intended. I believe there may have been some uncompiled code in SCSS files that got in when I've been compiling my changes. Feel free to drop this commit (if that's possible) - I could use some help with understanding the way of collaborating with SASS files, compilation adds an additional layer of challange in handling those files.

Also I think I should've split those two commits into separate PRs because they're basically two different issues now, but I'm not sure how to do it now, sorry for the mess.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lc-hr-cw ✅ Ready (Inspect) Visit Preview Dec 24, 2022 at 11:52AM (UTC)