search

mathcodes / contentfordevelopers

We aim to please users with not just another solution bank to leetcode problems, but more. Contributors are encouraged to upload and share any additional content such as visual diagrams, animated GIFs, notes, charts, or whatever they use to not only solve, but UNDERSTAND the problem at hand.
https://www.contentfordevelopers.com/
MIT License
33 stars 31 forks source link

added a Carousel #161

Closed Jayaditya-Contributor closed 1 year ago

Jayaditya-Contributor commented 1 year ago

Greetings @mathcodes

I have added a carousel , using react slick package (docs :- https://react-slick.neostack.com/ )

I could not manipulate the carousel buttons for some reason, and at first I wanted to add a gradient border ,But after sometime I felt backgroud gradient is more good , Hope u dont mind 🙏....

I became rusty in CSS , I need to brush up a bit If you have any, please reccomend any good resource to learn tailwindcss 😊....

Thanks

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
lc-hr-cw ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 15, 2023 at 1:12PM (UTC)
mathcodes commented 1 year ago

I like the carousel, nice work. One thought I had is it kind of takes away from providing the contributors with the credits they deserve (only the first few will realistically by seen ...). BUT, let's merge and utilize this somewhere throughout the app as a reusable component, and I'll change the main contributors sections back to show all the devs.

Great work, thanks for your input.

@everyone There are LOTS more to grab that are as simple and fun as this, and with some GREAT DEVS putting in hard work while I and others continue to load more and more content, we are on the way to something incredible here. Would love to keep you on board!

-Jon (@mathcodes)

mathcodes commented 1 year ago

@Jayaditya-Contributor consider adding some responsiveness to this. For example: displaying 6 slides on lg and up, 3 or 4 on md, 2 on sm, and 1 on xs... (just throwing those out there, experiment if you feel like tackling this!

Jayaditya-Contributor commented 1 year ago

Sir, I honestly felt my contributions was NOT taking the project to the new heights ,and i felt my contributions were just bothering the new updates. so i took a step back...

mathcodes commented 1 year ago

I apologize for the delay in merging. If that's got anything to do with how you feel, disregard that... that's my fault. I've been tied up with other projects. But no pressure. This is a pretty laid back, learning atmosphere, so let me know if there is anything I can do do make you feel more at home... I'd be happy to work on a PR with you if you'd like... but again, no pressure. I appreciate all you done thus far!

Jayaditya-Contributor commented 1 year ago

As soon as I tackle my college assignments, I will surley make changes to the carousel as you requested , It would be helpful (If I may ask) providing a refrence on the design of the carousel and the look on various devices .

Thank U @mathcodes