mathematic-inc / ts-japi

A highly-modular (typescript-friendly)-framework agnostic library for serializing data to the JSON:API specification
Apache License 2.0
203 stars 16 forks source link

[BUG] Illegal character (: in windows) used in the file name #11

Closed DManavi closed 4 years ago

DManavi commented 4 years ago

Describe the bug

A colon is an invalid character for a Windows file name. You won't be able to allow ':' in the file name and you used it in the file src/interfaces/json:api.interface.ts.

To Reproduce

Install this package as a dependency to a NodeJS project and run it.

Expected behavior*

Rename the file and use either dash or underscore as a separator.

Screenshots

image

Platform

jrandolf commented 4 years ago

I'll compile this in the next minor.

DManavi commented 4 years ago

Thanks. It would be great if you could publish it sooner. I believe that this package is used in both production and development projects so patching this critical bug (since it prevents the application from starting) would be a good idea.

jrandolf commented 4 years ago

It's out :)