mathematic-inc / ts-japi

A highly-modular (typescript-friendly)-framework agnostic library for serializing data to the JSON:API specification
Apache License 2.0
202 stars 15 forks source link

Add assertions to issue-23 test (testing depth > 1) #25

Closed jaridmargolin closed 3 years ago

jaridmargolin commented 3 years ago

Description

Replace console logging with assertions to ensure future updates do not cause regressions.

Additional Notes

I removed the counters because they did not provide value for this particular issue. Subsequent issues/tests will reintroduce the concept of counters to ensure fetch is called efficiently.

changeset-bot[bot] commented 3 years ago

🦋 Changeset detected

Latest commit: 6d37e54bc241ac98eaa66a892fe89f254af1a5dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------- | ----- | | ts-japi | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

jrandolf commented 3 years ago

May be better to snapshot test this inline,

jaridmargolin commented 3 years ago

I'm personally not a huge fan of snapshot testing (numerous reasons), but if that is the convention used in this project, I can try to apply the update.