search

mathertel / DmxSerial2

An Arduino library for sending and receiving DMX RDM packets.
BSD 3-Clause "New" or "Revised" License
99 stars 30 forks source link

Last remaining compiler warning in DMSSerial.cpp #21

Open g0uus opened 6 years ago

g0uus commented 6 years ago

Sign/Unsigned comparison warning on line 791 for (int n = 0; n < _initData->additionalCommandsLength; n++) {

RDMINIT.additionalCommandsLength is declared as uint16_t

Simple fix is to replace int n by uint16_t n.

This is the last remaining Compiler warning in DMXSerial itself. The warnings from EEPROM.h have been fixed in ArduinoCors-Avr/Libraries/EEPROM.h but not yet released!

peternewman commented 6 years ago

This is the last remaining Compiler warning in DMXSerial itself. The warnings from EEPROM.h have been fixed in ArduinoCors-Avr/Libraries/EEPROM.h but not yet released!

Have you got a link to the EEPROM stuff? It's what's blocking one of my Travis builds somewhere, and if fixed would mean we could add warning/error checking here too (although it still needs enabling for the main repo).

g0uus commented 6 years ago

https://github.com/arduino/ArduinoCore-avr/commit/6848ea443cfb118d01ae317c0e676c1629199fdb

Actually released in Arduino AVR Boards 1.6.23 - just downloaded. Building for Uno using Arduino 1.8.7.

I now get a single warning when building the RDMSerialRecv sample at EEPROM.h:145 that static EEPROMClass EEPROM is unused :(

Haven't time to investigate at the moment though.