search

mathertel / DmxSerial2

An Arduino library for sending and receiving DMX RDM packets.
BSD 3-Clause "New" or "Revised" License
99 stars 30 forks source link

Proper response for DMX_START_ADDRESS (get+set) #3

Closed Drachenkaetzchen closed 10 years ago

Drachenkaetzchen commented 10 years ago

According to the specs, the PDL must be 0 for E120_SET_COMMAND E120_DMX_START_ADDRESS and 2 for E120_GET_COMMAND E120_DMX_START_ADDRESS.

I noticed that because OLA was complaining; this pull request fixes this.

peternewman commented 6 years ago

See my response here @saiteja9429 : https://github.com/mathertel/DmxSerial2/pull/7#issuecomment-414081140

saiteja9429 commented 6 years ago

Hi Peter, How are you?

Can you please share the schematic for your code. So that if there is any mistake i can check and rectify it.

Thanks & Regards, Sai Teja

On Sun, Aug 19, 2018 at 1:00 AM Peter Newman notifications@github.com wrote:

See my response here @saiteja9429 https://github.com/saiteja9429 :

7 (comment)

https://github.com/mathertel/DmxSerial2/pull/7#issuecomment-414081140

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mathertel/DmxSerial2/pull/3#issuecomment-414081167, or mute the thread https://github.com/notifications/unsubscribe-auth/AdSxJSw2YiHwiLpvm8ddBrvVhaeU0Xy8ks5uSGtNgaJpZM4BTdys .