mathertel / DmxSerial2

An Arduino library for sending and receiving DMX RDM packets.
BSD 3-Clause "New" or "Revised" License
99 stars 30 forks source link

More compliance with the OLA RDM Tests #6

Closed peternewman closed 10 years ago

peternewman commented 10 years ago

Compliance with the OLA RDM Tests around sub devices and mute messages. Also with @nightrune get device specific PIDs returning properly in supportedParameters. Also make the device specific PIDs compliant with the OLA RDM Tests. Add device model ID option.

I has also found a bug, which exists with the January code before I touched it, running the following sequence of sets and gets causes timouts or similar messages during the RDM comms:

ola_rdm_set -u 2 --uid 0987:201269c6 device_label "test_label"; ola_rdm_get -u 2 --uid 0987:201269c6 device_label; ola_rdm_set -u 2 --uid 0987:201269c6 device_label "test_labe"; ola_rdm_set -u 2 --uid 0987:201269c6 device_label 'a'

peternewman commented 10 years ago

Hi @mathertel it would be great if this could be merged into mainline at some point when you get a chance. Let me know if there's anything I need to fix.

mathertel commented 10 years ago

Just merged it.

Thanks for your contribution !

Matthias

Von: peternewman [mailto:notifications@github.com] Gesendet: Samstag, 29. März 2014 02:16 An: mathertel/DmxSerial2 Cc: Matthias Hertel Betreff: Re: [DmxSerial2] More compliance with the OLA RDM Tests (#6)

Hi @mathertel https://github.com/mathertel it would be great if this could be merged into mainline at some point when you get a chance. Let me know if there's anything I need to fix.

— Reply to this email directly or view it on GitHub https://github.com/mathertel/DmxSerial2/pull/6#issuecomment-38982586 . https://github.com/notifications/beacon/1087895__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxMTY3NDk1OSwiZGF0YSI6eyJpZCI6MjQyMzE2MTd9fQ==--e0fc748d6f495b6ff0e6cfa9ac1bbc0a250df71b.gif