search

mathertel / OneButton

An Arduino library for using a single button for multiple purpose input.
http://www.mathertel.de/Arduino/OneButtonLibrary.aspx
Other
920 stars 230 forks source link

Add cppcheck #104

Closed mkinney closed 1 year ago

mkinney commented 2 years ago

See https://github.com/danmar/cppcheck/ or https://cppcheck.sourceforge.io/ for more info about cppcheck

and for the github action:

https://github.com/marketplace/actions/cppcheck-action

I excluded the "knownConditionTrueFalse" in the suppressions.txt file. May want to look into that.

mkinney commented 2 years ago

I have not tested that github action, so it make take some tweaking.

mkinney commented 2 years ago

I was able to test the github action on my repo.

Let me know if you have any questions/suggestions/comments.

mathertel commented 2 years ago

Looks interesting. When you have finished the settings I will merge.

(Already saw one of your the results ([knownConditionTrueFalse]) This is usually removed by the optimizing compiler so is not in effect but surely can be cleaned up.

mkinney commented 2 years ago

I’m finished with it, so please merge if ok.

I would be grateful if the knownConditionTrueFalse could be fixed at some point.

thanks