mathertel
commented
10 years ago Hi Thomas,
You are perfectly right. I just fixed the code and uploaded it.
Regards, Matthias
Von: mammaspappa [mailto:notifications@github.com] Gesendet: Samstag, 30. August 2014 21:40 An: mathertel/RotaryEncoder Betreff: [RotaryEncoder] _pin1 and _pin2 not used in RotaryEncoder::tick(void) (#1)
Hi,
First of all, thank you for a very nice library!
I found one issue with the RotaryEncoder::tick(void) function, specifically lines 68 and 69
They should be changed to: int sig1 = digitalRead(_pin1); int sig2 = digitalRead(_pin2);
from : int sig1 = digitalRead(A2); int sig2 = digitalRead(A3);
As it works now it only reads pins A2 and A3 and not the pins used in the Encoder constructor.
Again, thank you for the very nice code!
/Thomas
— Reply to this email directly or view it on GitHub https://github.com/mathertel/RotaryEncoder/issues/1 . https://github.com/notifications/beacon/1087895__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcyNTA0NjgyMSwiZGF0YSI6eyJpZCI6NDExMzkxMTV9fQ==--183e3ab00311dc7b42a0ee2fad2db16808b67287.gif
Hi,
First of all, thank you for a very nice library!
I found one issue with the RotaryEncoder::tick(void) function, specifically lines 68 and 69
They should be changed to: int sig1 = digitalRead(_pin1); int sig2 = digitalRead(_pin2);
from : int sig1 = digitalRead(A2); int sig2 = digitalRead(A3);
As it works now it only reads pins A2 and A3 and not the pins used in the Encoder constructor.
Again, thank you for the very nice code!
/Thomas