search

mathertel / RotaryEncoder

RotaryEncoder Arduino Library
Other
339 stars 107 forks source link

defined(ARDUINO_AVR_NANO_EVERY) not work with Nano #30

Open stef-ladefense opened 3 years ago

stef-ladefense commented 3 years ago

thank for your library, is very good !

i use Nano, and the precompilator "defined(ARDUINO_AVR_NANO_EVERY)" not work for my arduino ide 1.8.13 the correct syntax is "defined(ARDUINO_AVR_NANO)"

2) in your exemple "AcceleratedRotator" exst 2 .ino strictely identical

best regard,

Stef

mathertel commented 3 years ago

These are 2 completely different boards with different processors: https://docs.arduino.cc/hardware/nano-every vs. https://docs.arduino.cc/hardware/nano.

stef-ladefense commented 3 years ago

you did not understand what i mean in your examples you use

if defined (ARDUINO_AVR_UNO) || defined (ARDUINO_AVR_NANO_EVERY)

the uno and the nano use the same microcontroller instead, we should write

if defined (ARDUINO_AVR_UNO) || defined (ARDUINO_AVR_NANO) || defined (ARDUINO_AVR_NANO_EVERY)

mathertel commented 3 years ago

I see, thanks for explaining - I got you wrong. Can you create a pull request ?