Exploration share link not working

mathesar-foundation / mathesar

Web application providing an intuitive user experience to databases.

https://mathesar.org/

GNU General Public License v3.0

2.32k stars 320 forks source link

Exploration share link not working #3452

Closed ghislaineguerin closed 6 months ago

ghislaineguerin commented 6 months ago

Description

When creating a share link for explorations and then navigating to the page, I'm getting a "No page found" error.

Expected behavior

The shared exploration should load.

To Reproduce

Go to an exploration and create a share link
Navigate to the link

seancolsen commented 6 months ago

I'm reproducing this.

I get the same behavior when viewing the share link as authenticated and anonymous.

seancolsen commented 6 months ago

@pavish heads up that I took a quick crack at this today just in case you ended up being short on time. At the very least, reviewing this PR will help you see where the problem is — within SharedExplorationRoute.svelte the database variable was undefined. I made some changes to the child components to allow a missing database, which I think is okay, but I'd like you to take a close look since you know more than me about what functionality to expect from the database share page.

pavish commented 6 months ago

See comment for root cause. This seems to be a backend regression. I'm reassigning this issue to me.