mathesar-foundation / mathesar

Web application providing an intuitive user experience to databases.
https://mathesar.org/
GNU General Public License v3.0
2.29k stars 317 forks source link

Make textarea inputs auto-expand to accommodate longer text fields on the record page #3470

Closed seancolsen closed 4 months ago

seancolsen commented 4 months ago

Fixes #3466

Before

All textarea inputs on the record page have the same height, regardless of their content.

img

After

Screencast_20240229_143539.webm

Additional thoughts

Checklist

Developer Certificate of Origin

Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
seancolsen commented 4 months ago

@pavish I've assigned you to review this PR. Please review from a code perspective, and also feel free to weigh in with your thoughts and opinions on the effect this change will have on usability. For context, this change stems from discussions that Kriti and Ghislaine and I have been having about how we can improve usability enough to move our CRM to Mathesar.

@ghislaineguerin and @kgodey, because our plans regarding this change were somewhat tentative, I've also assigned you to review this so that we can be certain it's worth merging. I'm hoping the attached screencap will give you a clear enough picture of how it works, but feel free to play with it locally too.

ghislaineguerin commented 4 months ago

@seancolsen Looks good to me.