mathesar-foundation / mathesar

Web application providing an intuitive user experience to databases.
https://mathesar.org/
GNU General Public License v3.0
2.29k stars 317 forks source link

Extend mathesar to support python 3.10 and above #3478

Closed Anish9901 closed 4 months ago

Anish9901 commented 4 months ago

Fixes #3485

Technical details

This PR extends mathesar to support Python versions 3.10, 3.11, and 3.12! This also adds the same in the testing matrix and the python tests are set up to be run with the cross-product of each supported python version with each supported postgres version.

Checklist

- [x] My pull request has a descriptive title (not a vague title like `Update index.md`). - [x] My pull request targets the `develop` branch of the repository - [x] My commit messages follow [best practices][best_practices]. - [x] My code follows the established code style of the repository. - [ ] I added tests for the changes I made (if applicable). - [ ] I added or updated documentation (if applicable). - [x] I tried running the project locally and verified that there are no visible errors. [best_practices]:https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53 ## Developer Certificate of Origin
Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
kgodey commented 4 months ago

@Anish9901 FYI there's a package called drf-friendly-errors-django-4 that should be a drop in replacement for drf-friendly-errors, I found it when testing 0.1.4 installation with 3.11, here's my notes.

https://pypi.org/project/drf-friendly-errors-django-4/

Anish9901 commented 4 months ago

I did try that package @kgodey, but it has some additional changes that conflicts with our current error codes and hence breaks some of our tests.

Anish9901 commented 4 months ago

I'm planning to handle doc changes regarding python version in #3445, as build from scratch is the only section in the docs where we mention python versions.

kgodey commented 4 months ago

@Anish9901 Please handle the doc changes in this PR, otherwise the docs won't be in sync with the code when this is merged. Also #3445 doesn't appear to be in this release, should it be?

mathemancer commented 4 months ago

@kgodey Regarding drf-friendly-errors, this is a temporary measure until we remove that dependency entirely.