search

mathesar-foundation / mathesar

Web application providing an intuitive user experience to databases.
https://mathesar.org/
GNU General Public License v3.0
2.29k stars 317 forks source link

Add PG 16 to testing matrix #3480

Closed Anish9901 closed 4 months ago

Anish9901 commented 4 months ago

Fixes #3477

This PR adds PostgresSQL 16 to both python and SQL testing matrices.

Checklist

- [x] My pull request has a descriptive title (not a vague title like `Update index.md`). - [x] My pull request targets the `develop` branch of the repository - [x] My commit messages follow [best practices][best_practices]. - [x] My code follows the established code style of the repository. - [ ] I added tests for the changes I made (if applicable). - [ ] I added or updated documentation (if applicable). - [x] I tried running the project locally and verified that there are no visible errors. [best_practices]:https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53 ## Developer Certificate of Origin
Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
kgodey commented 4 months ago

I checked for places where the docs need to be updated, It looks like https://docs.mathesar.org/installation/build-from-source/ just says "13 or newer" which doesn't need to be changed, and I don't think we specify the version anywhere else.

Do we want to upgrade the version in our Dockerfile to 16 as well?

pavish commented 4 months ago

Do we want to upgrade the version in our Dockerfile to 16 as well?

Since this is out of scope for this particular PR, I'm merging this in. @Anish9901 I hope you'll follow up on discussions regarding upgrading our PG version on the Dockerfile.

Anish9901 commented 4 months ago

Do we want to upgrade the version in our Dockerfile to 16 as well?

We could do that @kgodey, I don't have an opinion on this, however. @mathemancer what do you think?