Closed pavish closed 4 months ago
@ghislaineguerin @kgodey I've assigned you to review this PR to take a call on the UX considerations mentioned above for the language switcher that is visible on the login page, which was added as part of this PR.
@pavish I would just merge this as-is and make a separate GitHub issue for the UX concerns you've listed here, I agree that the experience could be improved but I don't think it's bad enough to block release / we can fix in the next release.
make a separate GitHub issue for the UX concerns you've listed here
Sounds good.
This PR Enables switching languages
Tasks:
Add docs for building po files in Wiki(added in https://github.com/mathesar-foundation/mathesar/pull/3489)Show language switcher dropdown in password change page and superuser creation page?(Out of scope for this PR)UX considerations
Checklist
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`). - [x] My pull request targets the `develop` branch of the repository - [x] My commit messages follow [best practices][best_practices]. - [x] My code follows the established code style of the repository. - [ ] I added tests for the changes I made (if applicable). - [ ] I added or updated documentation (if applicable). - [x] I tried running the project locally and verified that there are no visible errors. [best_practices]:https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53 ## Developer Certificate of OriginDeveloper Certificate of Origin
``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```