mathesar-foundation / mathesar

Web application providing an intuitive user experience to databases.
https://mathesar.org/
GNU General Public License v3.0
2.29k stars 317 forks source link

Fix regression with record selector not filtering #3488

Closed seancolsen closed 4 months ago

seancolsen commented 4 months ago

Fixes #3487

This is a regression caused by #3470

Checklist

Developer Certificate of Origin

Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
seancolsen commented 4 months ago

@pavish this is a straightforward enough fix that I'm merging it now without review. Please review retroactively if you like.

seancolsen commented 4 months ago

In my opinion this regression stems from the fact that (annoyingly) there is no way to forward all events through a component. I've noted this in my extended rant on Svelte events, specifically within the "Forwarding" row of the comparison table. Based on some preliminary reading I've done on Svelte 5, my initial impression is that they're seeking to fix this by changing the way events work. I hope this gets better with Svelte 5.