search

mathesar-foundation / mathesar

Web application providing an intuitive user experience to databases.
https://mathesar.org/
GNU General Public License v3.0
2.29k stars 317 forks source link

GH workflow to create draft release with built static files #3489

Closed pavish closed 4 months ago

pavish commented 4 months ago

Fixes #2871

Details

Checklist

- [x] My pull request has a descriptive title (not a vague title like `Update index.md`). - [x] My pull request targets the `develop` branch of the repository - [x] My commit messages follow [best practices][best_practices]. - [x] My code follows the established code style of the repository. - [ ] I added tests for the changes I made (if applicable). - [ ] I added or updated documentation (if applicable). - [x] I tried running the project locally and verified that there are no visible errors. [best_practices]:https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53 ## Developer Certificate of Origin
Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
Anish9901 commented 4 months ago

@pavish #3198 might be relevant, instead of creating a draft release it creates and uploads static assets once a release is created/edited.

pavish commented 4 months ago

@Anish9901

instead of creating a draft release it creates and uploads static assets once a release is created/edited.

The current plan is to automate creating a draft release with the frontend static assets when a tag is created, when a release branch is cut. Refer this mail thread.

pavish commented 4 months ago

This introduces changes to our release process. I will raise a separate PR for it on the wiki repo.

seancolsen commented 4 months ago

@pavish I'm a little confused about the workflow here. You said:

This introduces changes to our release process. I will raise a separate PR for it on the wiki repo.

I think that once I read that PR I'll either be satisfied or I'll have some more specific questions to ask. So I'm going to hold off on reviewing this until I can read the wiki PR in conjunction.

Anish9901 commented 4 months ago

I don't see any releases on the fork you linked @pavish, I think it'd be helpful if you could also link the asset in this PR.

pavish commented 4 months ago

@Anish9901 Draft releases aren't visible. I published it, here's how it looks: https://github.com/pavish/mathesar/releases/tag/0.1.6

pavish commented 4 months ago

I think that once I read that PR I'll either be satisfied or I'll have some more specific questions to ask. So I'm going to hold off on reviewing this until I can read the wiki PR in conjunction

@seancolsen The wiki PR is here: https://github.com/mathesar-foundation/mathesar-wiki/pull/109