mathesar-foundation / mathesar

Web application providing an intuitive user experience to databases.
https://mathesar.org/
GNU General Public License v3.0
2.36k stars 327 forks source link

Release notes v0.1.6 #3506

Closed Anish9901 closed 6 months ago

Anish9901 commented 6 months ago

Release notes for v0.1.6

Checklist

- [x] My pull request has a descriptive title (not a vague title like `Update index.md`). - [ ] My pull request targets the `develop` branch of the repository - [x] My commit messages follow [best practices][best_practices]. - [x] My code follows the established code style of the repository. - [ ] I added tests for the changes I made (if applicable). - [x] I added or updated documentation (if applicable). - [x] I tried running the project locally and verified that there are no visible errors. [best_practices]:https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53 ## Developer Certificate of Origin
Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
Anish9901 commented 6 months ago

I forgot to mention this in our last team meeting, do we need to add another page in our docs for v0.1.6 upgrade instructions if they are the same as v0.1.5?

pavish commented 6 months ago

I forgot to mention this in our last team meeting, do we need to add another page in our docs for v0.1.6 upgrade instructions if they are the same as v0.1.5?

@Anish9901

They're not the same as v0.1.5. We would need a separate page. There are changes in steps involved for Install from scratch. It's tracked in this issue: https://github.com/mathesar-foundation/mathesar/issues/3505

kgodey commented 6 months ago

We should also add a Basecamp task to 0.1.7 and the template to make sure we have upgrade instructions for the release, @Anish9901 can you do this?

kgodey commented 6 months ago

Some thoughts based on a quick skim, I'll review in more detail next week once these are addressed:

Anish9901 commented 6 months ago

@kgodey I've addressed your concerns in b5fc1a4 & f56a96a, The CI is failing as the linked page for upgrading to 0.1.6 doesn't exist yet and will be added once #3507 is merged. Please feel free to go through another round of review.

kgodey commented 6 months ago

We should also add a Basecamp task to 0.1.7 and the template to make sure we have upgrade instructions for the release, @Anish9901 can you do this?

Also @Anish9901 I didn't see a response to this so I just did it myself.

Anish9901 commented 6 months ago

We should also add a Basecamp task to 0.1.7 and the template to make sure we have upgrade instructions for the release, @Anish9901 can you do this?

Also @Anish9901 I didn't see a response to this so I just did it myself.

I added it under "Documentation" @kgodey

Screenshot 2024-03-27 at 2 49 52 AM
kgodey commented 6 months ago

@Anish9901 I see that now, thanks, I'll delete mine.

kgodey commented 6 months ago

I think your guidelines make sense, @seancolsen. Since there's not much left to do in the release process, I think it's fine to make these changes before release, unless @Anish9901 thinks they will take more than a day.

Anish9901 commented 6 months ago

If you didn't run the script, I'd like to understand why. Do you have an opinion against this script-based approach? Or could we improve our release notes process documentation to make this step more obvious?

I wasn't able to get the script running on a Mac @seancolsen, That's why I decided not to use it, I wasn't aware that it added a bunch of metadata about linked issues. I've got it to work using a linux machine now.

Here's the specific error that I was facing on a Mac:

anish@appy releases % ./find_missing_prs.sh 0.1.6
sed: 1: "0.1.6.md": invalid command code .
date: illegal option -- d
usage: date [-jnRu] [-I[date|hours|minutes|seconds]] [-f input_fmt]
            [-r filename|seconds] [-v[+|-]val[y|m|w|d|H|M|S]]
            [[[[mm]dd]HH]MM[[cc]yy][.SS] | new_date] [+output_fmt]
grep: invalid option -- P
usage: grep [-abcdDEFGHhIiJLlMmnOopqRSsUVvwXxZz] [-A num] [-B num] [-C[num]]
    [-e pattern] [-f file] [--binary-files=value] [--color=when]
    [--context[=num]] [--directories=action] [--label] [--line-buffered]
    [--null] [pattern] [file ...]
Binder Error: Table "pr" does not have a column named "mergeCommit"
LINE 7:     ON commit.hash = pr.mergeCommit
                             ^
No missing PRs
seancolsen commented 6 months ago

@Anish9901 it looks like you found some portability issues with my bash script. Wonderful! Instead of ignoring this script, I'd like to fix it. The hover text on PR hyperlinks is cool, but the main value proposition of the script is that it makes it really fast to generate the release notes. I've opened #3515 to track fixes to the script. I don't imagine this being too hard, so I think we could take it up for the next release.

In the mean time, it's great that you've found a work-around using Linux. I assume you can use this workflow to push changes that address my critique. Let me know if you need any help.