mathesar-foundation / mathesar

Web application providing an intuitive user experience to databases.
https://mathesar.org/
GNU General Public License v3.0
2.36k stars 327 forks source link

Data Import Error on Data Type Change for Non-URL Values in Columns #3512

Open ghislaineguerin opened 6 months ago

ghislaineguerin commented 6 months ago

Description

In data import, if a column contains non-url values, such as the following:

image

Attempting to update the data type under these circumstances results in a crash, accompanied by the following error message:

image

Expected behavior

When attempting a data type change for such a column, the operation should either complete successfully, or a clear notification should be provided, indicating that the data type change cannot be executed.

Status

As noted by @Anish9901, further work on this issues is blocked until we re-implement the previews logic with our RPC API.

hitenvidhani commented 5 months ago

Found a similar error [Video], is this behaviour expected or we want to show a clear warning message here for the user to understand?

kgodey commented 4 months ago

Tagging @seancolsen to take a look at @hitenvidhani's comment.

seancolsen commented 4 months ago

@hitenvidhani I agree it would be nice to improve the error message show in your attached video. Please open a separate ticket to track that though. It's a different issue than the one described here, and I don't want to add confusion to this thread. In general, please err on the side of opening new tickets for things like this, or ask in Matrix in cases where you're not sure if something warrants a ticket.