Closed hitenvidhani closed 2 months ago
Thank you @seancolsen . Could you please clarify how to sort imports? I followed this guide https://github.com/mathesar-foundation/mathesar/blob/develop/mathesar_ui/README.md and still they weren't sorted with format or lint.
Also I don't see these features on the demo site https://demo.mathesar.org/, is it only after the release it would reflect here?
Good questions, @hitenvidhani
how to sort imports
I use the "Organize Imports" action in VS Code. I have a keyboard shortcut set to do this. At some point I'd really like to get some tooling set up in our repo which does this for us. Ideally it would be something that integrates with Prettier so that we when run Prettier the imports are automatically sorted. I you are interested in working on that it could be a nice little self-contained project. I can help clarify the requirements if this is confusing.
demo site
We update it manually after each release. The develop
branch is not as stable as our releases. Like, we might have mid-cycle bugs that crop up during feature development. We make an effort to fix bugs like that during our QA phase before each release. So we don't want to run the demo site off the develop branch because such regressions could give people a bad impression of Mathesar.
Sure @seancolsen
I did a bit of research and it looks like we'd have to use the plugin prettier-plugin-svelte
and add specific rules for the files in .prettierrc
. It would be great if you could clarify the requirements further.
@hitenvidhani I opened #3542 with some clearer requirements. We can continue to discuss there.
Fixes #2350
Screenshots
On clicking a record which is inked
On clicking a record which is not linked
On clicking column name which is linked
On clicking column name not linked
Checklist
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`). - [x] My pull request targets the `develop` branch of the repository - [x] My commit messages follow [best practices][best_practices]. - [x] My code follows the established code style of the repository. - [ ] I added tests for the changes I made (if applicable). - [ ] I added or updated documentation (if applicable). - [x] I tried running the project locally and verified that there are no visible errors. [best_practices]:https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53 ## Developer Certificate of OriginDeveloper Certificate of Origin
``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```