search

mathesar-foundation / mathesar

Web application providing an intuitive user experience to databases.
https://mathesar.org/
GNU General Public License v3.0
2.36k stars 327 forks source link

Made release notes script portable. #3529

Closed kgodey closed 5 months ago

kgodey commented 5 months ago

Fixes #3515

Developer Certificate of Origin

Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
kgodey commented 5 months ago

This was working for me after these changes. Assigned to @Anish9901 to make sure it runs on a Mac and to @seancolsen to make sure it still runs on Linux and does what it supposed to.

seancolsen commented 5 months ago

I pushed some changes to further improve this so that it would work for me.

@Anish9901 perhaps you could test on both Mac OS and Linux?

Anish9901 commented 5 months ago

Looks good to me @seancolsen & @kgodey. I ran the script on Mac OS and Linux and upon diffing the outputs, I found no changes between them. On Mac OS, I did get a warning, but, I am fine with ignoring it.

Here is the exact warning that I was getting if you're curious:

<string>:3: DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC).