mathesar-foundation / mathesar

Web application providing an intuitive user experience to databases.
https://mathesar.org/
GNU General Public License v3.0
2.28k stars 316 forks source link

Password change error message UI/UX #3563

Closed hitenvidhani closed 1 month ago

hitenvidhani commented 2 months ago

Description

Some issues were discussed in this PR(https://github.com/mathesar-foundation/mathesar/pull/3536#issuecomment-2059968281) regarding password change error messages display.

  1. Error messages display in which language when a user in Japanese mode changes password?
  2. Alignment of error message.
  3. Some other issues which I saw while testing this(Video): Notice that I have selected Japanese mode but there are many untranslated pieces of text

Expected behavior

  1. Messages should be in Japanese which is happening currently so no changes required there image
  2. Alignment of the messages should be in sync with the button above the error message
  3. All the text should be in Japanese, I suppose. If not, I believe at least the info message should be in Japanese.

To Reproduce

Try setting or changing password that it invalid (which doesn't contain any special character)

Environment

Additional context

### Tasks
seancolsen commented 1 month ago

@hitenvidhani This issue is a bit hard to understand. Before we proceed, I'd like you to clean it up.

Unless I'm missing something, I think we can close this issue once you've taken the steps above.

hitenvidhani commented 1 month ago

Created a new issue https://github.com/mathesar-foundation/mathesar/issues/3603, hence closing this one.

Are you expecting the left edge of the error message to be horizontally aligned with the left edge of the cancel button?

Yeah, but it can be ignored currently as you said.