mathesar-foundation / mathesar

Web application providing an intuitive user experience to databases.
https://mathesar.org/
GNU General Public License v3.0
2.28k stars 316 forks source link

Logging in - new user - i18n issue #3603

Closed hitenvidhani closed 4 weeks ago

hitenvidhani commented 1 month ago

Description

The text displayed while logging in with credentials of a newly created user and selecting language(at the time of login) as Japanese is shown in English. Screenshot from 2024-05-19 01-34-31

Expected behavior

The text should be in Japanese instead of English

To Reproduce

  1. Create a new user from admin account
  2. Log out from admin user
  3. Enter new user's credentials [created in step 1] and select language as Japanese and log in
  4. It will show the screen with text in English [screenshot in description above]

    Environment

    • OS: (eg. macOS 10.14.6; Fedora 32)
    • Browser: (eg. Safari; Firefox)
    • Browser Version: (eg. 13; 73)
    • Other info:

Additional context

balachander712 commented 1 month ago

Hi @hitenvidhani @seancolsen,

This issue is because the translation was present in the .mo file but was missing in the .po file. Recompiling the messages fixed the issue.

python manage.py compilemessages . I spun up the docker-container by adding the above command to the dev.sh file and django was successfully able to translate the page.

Screenshot 2024-06-02 at 23 10 00

Attaching the page for your reference.

Thanks and Regards, Balachander

seancolsen commented 4 weeks ago

Thanks for troubleshooting this, @balachander712! I've verified your findings too. That .po file is also regenerated when the development Docker container is rebuilt. So I think the main take-away here is that developers need to rebuild their docker container if they ever notice any missing translations. I'll keep this in mind when triaging issues in the future. I'm closing this now since I don't think any code changes are needed.