Moves all old DB-object models to a deprecated namespace
Moves UIQuery model to Exploration
Moves old Database model to Connection
Adds new Server, Database, Role, UserDatabaseRoleMap models
It does not implement actually using the new models in any RPC functions. I was trying to keep the changes as small as possible.
Technical details
I tried to keep this PR minimal, but it's a major overhaul. The updated diagram for the relevant models is:
Note that Exploration isn't included in this diagram because it's not wired in yet. Also, I had to add some redundant foreign keys from the UserDatabaseRoleMap model:
from database to Database
from role to Role
from server to Server.
These were necessitated by the way Django works. Basically, these were added since we want to be able to traverse those fields as related in python.
Also, the multicolumn foreign keys aren't visible in the service layer. They're just added as custom SQL migrations to enforce integrity.
Finally, all tests are currently passing, but no new tests are added. We'll add tests for actual functionality using these models as appropriate.
Checklist
- [X] My pull request has a descriptive title (not a vague title like `Update
index.md`).
- [X] My pull request targets the `develop` branch of the repository
- [X] My commit messages follow [best practices][best_practices].
- [X] My code follows the established code style of the repository.
- [ ] I added tests for the changes I made (if applicable).
- [ ] I added or updated documentation (if applicable).
- [X] I tried running the project locally and verified that there are no
visible errors.
[best_practices]:https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53
## Developer Certificate of Origin
Developer Certificate of Origin
```
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
```
Fixes #3625
deprecatednamespaceUIQuerymodel toExplorationDatabasemodel toConnectionServer, Database, Role, UserDatabaseRoleMapmodelsIt does not implement actually using the new models in any RPC functions. I was trying to keep the changes as small as possible.
Technical details
I tried to keep this PR minimal, but it's a major overhaul. The updated diagram for the relevant models is:
Note that
Explorationisn't included in this diagram because it's not wired in yet. Also, I had to add some redundant foreign keys from theUserDatabaseRoleMapmodel:databasetoDatabaseroletoRoleservertoServer.These were necessitated by the way Django works. Basically, these were added since we want to be able to traverse those fields as related in python.
Also, the multicolumn foreign keys aren't visible in the service layer. They're just added as custom SQL migrations to enforce integrity.
Finally, all tests are currently passing, but no new tests are added. We'll add tests for actual functionality using these models as appropriate.
Checklist
- [X] My pull request has a descriptive title (not a vague title like `Update index.md`). - [X] My pull request targets the `develop` branch of the repository - [X] My commit messages follow [best practices][best_practices]. - [X] My code follows the established code style of the repository. - [ ] I added tests for the changes I made (if applicable). - [ ] I added or updated documentation (if applicable). - [X] I tried running the project locally and verified that there are no visible errors. [best_practices]:https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53 ## Developer Certificate of OriginDeveloper Certificate of Origin
``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```