Open seancolsen opened 6 days ago
Heads up that I just realized that common_data
is still broken here. The schemas load when the page is loaded client-side, but not when it's loaded fully from the server. I think I'd like to handle that in a separate PR.
Thanks @Anish9901, that works.
Marking as a draft because I realized that some more changes are needed to the front end data structures.
Sorry — never mind. After some additional digging, I the problem I though I had identified was not actually there.
Ready for review now.
Notes
This PR implements the front end side of our RPC refactor for the following REST endpoints:
/api/db/v0/schemas/{schemaId}/
schemas.delete
/api/db/v0/schemas/{schemaId}/
schemas.patch
/api/db/v0/schemas/
schemas.list
/api/db/v0/schemas/
schemas.add
Working functionality
Notable user-facing changes
Exploration counts are removed from each schema card
We discussed this previously and made this choice in order to simplify implementation.
Broken functionality
Basically every other page of Mathesar is broken except for the root page which shows connections.
For example, the schema page looks like this:
Checklist
Update index.md
).develop
branch of the repositoryDeveloper Certificate of Origin
Developer Certificate of Origin
``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```