search

matheuscas / pycpfcnpj

Python module for brazilian register numbers for persons (CPF) and companies (CNPJ).
MIT License
143 stars 44 forks source link

Adding support to unicode values #17

Closed riquellopes closed 6 years ago

riquellopes commented 6 years ago

Hi,

l Would like to added support to unicode values.

codecov[bot] commented 6 years ago

Codecov Report

Merging #17 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #17   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      7           
  Lines          83     84    +1     
=====================================
+ Hits           83     84    +1
Impacted Files Coverage Δ
pycpfcnpj/compatible.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 982920a...817cfdf. Read the comment docs.

matheuscas commented 6 years ago

Hi @riquellopes , this is great. But, would u mind to expand the tests? Like, try to test unicode in all other cases, such as CNPJ with and without masks, masked CPF, etc. Got it? Thanks again for your PR.

riquellopes commented 6 years ago

Hi,

@matheuscas . I added a new tests to cover another cases.

riquellopes commented 6 years ago

Hi @matheuscas,

Would you like me to do another modification?