matheusd / dcr-split-ticket-matcher

Decred Split Ticket Matcher Service & Client
ISC License
28 stars 7 forks source link

Implement more thorough buyer tests #55

Open matheusd opened 5 years ago

matheusd commented 5 years ago

Once the architectural rewrite of #54 is done, the buyer will be able to use pluggable backends for issuing the network calls to the wallet and the service.

Once this is done, we can write more thorough tests for simulating the buyer behavior by mocking the results of network calls at a higher level.

The main tests that I'd like to add are related to spoofing and attempts at gaming the buyer (eg: replacing the buyer vote address, sending buyer-controlled extra inputs for signing) to increase confidence that the buyer code is actually performing these checks.