Closed brunaw closed 2 years ago
Following up this issue, would that be a typo in the book {"pred_m_pred": m2.predict(prices_rnd[X])} instead of m1.predict(prices_rnd[X])? Thank you.
Hi, @brunaw. The evaluation here is invariant to scale. It order the observations by the score and builds the evaluation on such ordering, not on the raw score.
@Jayzhaowj , you are correct. It was a typo. Thanks!
In Chapter 19 - Evaluating Causal Models, you propose a 'random model' that samples from a ~Unif(0, 1) distribution, and that doesn't match the context of the problem (how can you compare something in [0,1] with something on a completely different scale?). It would probably be clearer if you sampled from a ~Unif(min(sales), max(sales)), e.g.:
because that would be on the same scale as the data. Does that make sense?