search

matheusgomes28 / urchin

Headless CMS written in Golang
MIT License
60 stars 19 forks source link

check database connection #53

Closed Milad75Rasouli closed 5 months ago

Milad75Rasouli commented 5 months ago

Here is my change. let me know if it works well

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 23.83%. Comparing base (b9d3e53) to head (5257734).

Files Patch % Lines
database/database.go 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #53 +/- ## ========================================== - Coverage 23.95% 23.83% -0.12% ========================================== Files 14 14 Lines 643 646 +3 ========================================== Hits 154 154 - Misses 472 475 +3 Partials 17 17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

matheusgomes28 commented 5 months ago

Looks good, tested and worked with all the cases:

Coverage isn't passing but this is pretty much unreachable code from the unit tests. I'll do some sort of functional tests and cover it later on in this project. Thanks for the change.