search

matheusgomes28 / urchin

Headless CMS written in Golang
MIT License
60 stars 19 forks source link

(#77) DELETE posts requests: #89

Closed AlDu2407 closed 3 months ago

AlDu2407 commented 3 months ago
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 38.40%. Comparing base (86f0ef8) to head (b8644c2). Report is 8 commits behind head on main.

:exclamation: Current head b8644c2 differs from pull request most recent head b2eba47

Please upload reports for the commit b2eba47 to get more accurate results.

Files Patch % Lines
database/database.go 0.00% 9 Missing :warning:
admin-app/post.go 0.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #89 +/- ## ========================================== - Coverage 43.42% 38.40% -5.02% ========================================== Files 16 15 -1 Lines 760 716 -44 ========================================== - Hits 330 275 -55 - Misses 386 409 +23 + Partials 44 32 -12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

AlDu2407 commented 3 months ago

As usual, thank you very much for the contribution Al! I left some minor comments, I realised that the post add endpoints still work when we remove crucial data like title, excerpt etc.

I'm happy to let these pass for now but I'll create issues to fix that 😄

Let's not merge it then. Let me fix the behaviour of the POST /posts endpoint to behave properly. I wouldn't want to merge something that is half finished.