package.json missing - Githubissues

mathew-kurian / Scribe.js

:scroll: Node.js logging made simple! Online access to logs and more...

https://mathew-kurian.github.io/Scribe.js/

MIT License

284 stars 45 forks source link

package.json missing #2

Closed tonila closed 10 years ago

tonila commented 10 years ago

Please add package.json to root of the project, to make this installable with npm.

npm install --save git+https://github.com/bluejamesbond/Scribe.js.git
npm ERR! Error: ENOENT, open \package\package.json'

mathew-kurian commented 10 years ago

I will work on this and push out a fix soon.

gauthamchandra commented 10 years ago

@tonila, @bluejamesbond . I am currently working on this now. I forked your code and am making the necessary changes. I also would need to make changes to the source code to add a few things such as:

Removing the need to place the scribe script in a specific directory
Allow it to be installed via npm directly without referring to the repo (although I will let you publish it to the npm registry since its your work after all)
Setup Grunt and Write up unit tests for it

Most of this will take a bit of time (as im currently bogged down by work) but the first part (making it an npm module and such, I will try to have in the form of a pull request in 2 weeks.

mathew-kurian commented 10 years ago

@gauthamchandra Thank you very much! Please keep me posted. Step 3 is new to me so this will be a good learning experience.

mathew-kurian commented 10 years ago

@gauthamchandra Let me know what your progress is. Your help is appreciated.

gauthamchandra commented 10 years ago

Ah yes sorry about that. I will push some of the code in the next few days. Been pretty busy lately because of work.

mathew-kurian commented 10 years ago

Its cool. Just a heads up, I have made updates to the repo since then.

gauthamchandra commented 10 years ago

Ok. Will look into them.

I am making some extensive changes to your code (not really functionality wise) but adding a bunch of things like:

Not overriding console but instead using console internally
Adding the package.json and adding all the code to make it a proper npm package (will of course give you the option to publish it)
Adding unit testing, linting and a few other grunt tasks.
Some additional cleanup

Will push code in 2-3 days. I have been seriously the past few weeks and have been trying to catch up.

NOTE: I checked the npm registry. There are multiple packages named Scribe. You might want to slightly change the name of the package (ScribeLogger maybe? I don't know).

zckrs commented 10 years ago

@gauthamchandra Where is PR ? :smile: "Long time no see."

@bluejamesbond What do you think 'beautify-logger' to name this package on NPM ?

mathew-kurian commented 10 years ago

I have added the package.json and test cases.