mathew-kurian / Scribe.js

:scroll: Node.js logging made simple! Online access to logs and more...
https://mathew-kurian.github.io/Scribe.js/
MIT License
284 stars 45 forks source link

Added missing code for the example to be standalone #9

Closed frostyandy2k closed 10 years ago

frostyandy2k commented 10 years ago

Hi This is some nice stuff you built. Unfortunately it took me 3 hours to make it run. I admit that I am a newbie but I think it is generally valid to have a copy-paste working example of your software. I hope that you accept my critique and the pull request so that other people will find it easier to work with this nice piece of code with such a great design.

mathew-kurian commented 10 years ago

Thank you very much! Please refer to the following commit: https://github.com/bluejamesbond/Scribe.js/commit/39485f123d028579fb40d472e4a7586b30623117

I have resolved the problem there.

frostyandy2k commented 10 years ago

Hi

Would you consider renaming the src folder to ‘scribe' or making it a NodeJS module, testing and enhancing the code and then committing it to a fork will be much easier. Or maybe I am doing it wrong.

Regards Andrei

On 31 Jul 2014, at 21:50, Mathew Kurian notifications@github.com wrote:

Thank you very much! Please refer to the following commit: 39485f1

I have resolved the problem there.

— Reply to this email directly or view it on GitHub.

frostyandy2k commented 10 years ago

Hi

I tried the code again. To be honest, it is very complicated to start the example, I believe many people will be deterred by the incomplete example. Especially people not familiar with express will not be able to make it work at all, because they may believe that the ‘app’ is part of the library. It also shows the integration with express.

I think a complete copy-paste example is important. It would be nice if people used Scribe more, it’s a nice helper.

Best, Andrei

On 31 Jul 2014, at 21:50, Mathew Kurian notifications@github.com wrote:

Thank you very much! Please refer to the following commit: 39485f1

I have resolved the problem there.

— Reply to this email directly or view it on GitHub.

mathew-kurian commented 10 years ago

I hope it is fixed now. Please refer to the latest version.