search

mathew-kurian / TextJustify-Android

:page_facing_up: Android Text Full Jusiftication / Wrapping / Justify / Hyphenate - V2.0
https://github.com/bluejamesbond/TextJustify-Android/wiki
Apache License 2.0
1.86k stars 369 forks source link

Multiple quality improvements #116

Closed m-ezzat closed 8 years ago

m-ezzat commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rules squid:S2131 - Primitives should not be boxed just for "String" conversion squid:S2039 - Member variable visibility should be specified squid:S1854 - Dead stores should be removed

You can find more information about the issues here: https://dev.eclipse.org/sonar/coding_rules#q=squid:S2131 https://dev.eclipse.org/sonar/coding_rules#q=squid:S2039 https://dev.eclipse.org/sonar/coding_rules#q=squid:S1854

Please let me know if you have any questions.

M-Ezzat

mathew-kurian commented 8 years ago

I am closing this PR as these more syntax oriented rather than structure/procedure

m-ezzat commented 8 years ago

It's not just syntax you can find the description of the first, second and third rules, you will also find their categories Efficiency > Memory use, Reliability > Instruction and Reliability > Data respectively. Of course, it's your product and up to you. Thanks!