search

mathewdbutton / fds-sanity-checker

FDS Sanity Checker is an opinionated validation tool for your FDS models.
GNU General Public License v3.0
0 stars 0 forks source link

Issue with radiative heat flux checker #2

Open HarrietEnZed opened 2 years ago

HarrietEnZed commented 2 years ago

Hi, my model has radiative heat flux gauges but the checker is not recognising them. I believe it might be because my devices are referred to as "radiative heat flux gas" when the checker might just be looking for "radiative heat flux"

Here is a sample of the code I was putting in (truncated for sensitivity)

RadFluxMeterCode.txt

Can you also please put the File/Chid name on the checker results page?

mathewdbutton commented 2 years ago

I believe it might be because my devices are referred to as "radiative heat flux gas" when the checker might just be looking for "radiative heat flux"

The requirements for this validation check are a little murky. Currently it's only looking for "radiative heat flux" as you say however this might not even be a relevant check. See here https://github.com/mathewdbutton/fds-sanity-checker/blob/main/app/models/heat_flux_device_orientation_status.rb#L12 it's currently filtering for only the "radiative heat flux". I'll do some more digging.

Can you also please put the File/Chid name on the checker results page?

@HarrietEnZed can do!

mathewdbutton commented 2 years ago

Once this deploy is done, the CHID will be displayed on the validation results page.

Now with added tooltips telling you where it comes from Screen Shot 2022-06-11 at 11 03 27 pm