search

mathewthe2 / Game2Text

Complete toolbox for gamifying language learning
https://www.Game2Text.com
Apache License 2.0
194 stars 26 forks source link

Support for Edge (Chromium) #25

Open CrescentKohana opened 3 years ago

CrescentKohana commented 3 years ago

Current version of Game2Text doesn't work with Edge (Chromium). It should easily fixable as it's basically just Chrome. I'm guessing changing IE.HTTP from this line to MSEdgeHTM might be enough.

I'm also proposing dropping support for the Legacy Edge completely as it's not supported anymore anyway:

Additionally, we will be ending support for the legacy version of the Microsoft Edge desktop app on March 9, 2021, in favor of the new Microsoft Edge. This means that the legacy version of the desktop app will no longer receive security updates.

Though if for some reason you'd like to keep the support for the legacy version anyway, I would just change the name used in the config to legacy_edge and keep the name edge for the new Chromium version.

Tested on:

CrescentKohana commented 3 years ago

I just noticed that it does work when the config option is set to default. The problem is just with the keyword edge.

mathewthe2 commented 3 years ago

I'm assuming Edge is not your default browser?

CrescentKohana commented 3 years ago

It is. Also the registry key ProgId in Computer\HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\Shell\Associations\UrlAssociations\http\UserChoice is MSEdgeHTM.