Open carloscheddar opened 1 year ago
I'm fine with adding options to allow online dictionaries, but can you explain the motivation for preferring that as the default over a local dictionary?
Also, there are way too many commits for this one PR, many of which seemingly unrelated to the core function of adding jisho aoi, for example, function refactors, and moving logic to files.
It would be great if you can break up those changes to separate PRs.
So the way I came about this was that I wanted to use JMDict Extra to match my yomichan dictionary but the structured content
couldn't be read by Game2Text. After I fixed that I realized that I wanted to add richer data to the Anki card which would need "parts of speech"(adjective, noun, ichidan verb, etc.) while this is available in dictionaries the jisho api that I've used before offered an easier way to access this data so I went ahead and implemented that. I also noticed that some yomichan results had audio while the same entry didn't have audio on Game2Text so I looked into why that was and fixed that.
I agree about the long PR I got carried away trying to make things work like I wanted to on my end that I forgot to break it down into parts. I'll look into making separate PRs.
Updates the existing Anki integration with more fields in order to create more detailed cards that include translations, more definitions, sound search improvements, etc. I've included a sample Anki deck which I've been using with this implementation.
Changes
logs.js
file into a newankicard.js
file.extractOtherForms
.