search

mathewthe2 / Game2Text

Complete toolbox for gamifying language learning
https://www.Game2Text.com
Apache License 2.0
186 stars 24 forks source link

Misc fixes #51

Closed ubitux closed 11 months ago

ubitux commented 12 months ago

Here are a bunch of fixes for issues I came across while trying to make the project work on Linux and browsing the codebase.

Note that this PR doesn't include changes I needed but are a bit too radical. In particular, I had to upgrade all the requirements (a large number of them simply wouldn't compile).

While there are still many things that do not work in the current state (starting from Yomichan popup not showing up), at least now it starts.

One more thing while I'm at it: would a PR to reformat the whole codebase with black/isort accepted? Overall, I'd be happy to modernize the codebase a bit (packaging, use of common Python idioms, etc)

mathewthe2 commented 12 months ago

Regarding the path for Linux and MacOS, I'm thinking of moving it to config.ini, and applying a default value on the platform that the app is built on.

The other formatting patches look good to me. I'll have a run later to see if it works on my machine.

ubitux commented 12 months ago

Regarding the path for Linux and MacOS, I'm thinking of moving it to config.ini, and applying a default value on the platform that the app is built on.

Speaking of config, shouldn't the Anki fields mapping be in that file as well instead of its own yaml?

mathewthe2 commented 12 months ago

Speaking of config, shouldn't the Anki fields mapping be in that file as well instead of its own yaml?

Possible. I was expecting use cases where there would be multiple mappings when I first built the app and thought it should have its own file.