mathewthe2 / immersion_reader

iOS Reader with Japanese popup dictionary
MIT License
29 stars 2 forks source link

Some definitions appear twice #9

Open miya-sans opened 1 year ago

miya-sans commented 1 year ago

Device: iPad Pro (12.9 inch) (6th gernation) iOS Version: 16.3.1 Version: 1.8 (from appstore)

Using the JMDict english from https://foosoft.net/projects/yomichan/index.html#dictionaries, some definitions would appear twice. Also tried with my own converted version of CEDICT, so it seems to be dictionary independent. See video, in fact the same word will like 誘拐 will have a definition that appears twice, and all the others appear once. Book is ePUB converted using Calibre, just rename the extension.

book.zip

https://user-images.githubusercontent.com/42623210/227659855-7ef16188-d27f-444a-b5bd-9e5629c9d447.mp4

IMG_0037

mathewthe2 commented 1 year ago

Do you still see this bug with a fresh installation? It could be an issue with data integrity when a previously installed dictionary hasn't been completely removed.

(To have a fresh installation, completely remove the app before installing the app from the app store.)

Simulator Screen Shot - iPhone 14 Pro Max - 2023-03-25 at 18 07 47

miya-sans commented 1 year ago

I did a fresh install and found the problem dictionary:

This yomichan CEDICT that I made from the source: cedict.zip

After uninstalling this dictionary, the problem will persist.

IMG_0038

Screenshot 2023-03-25 at 2 34 02 png
miya-sans commented 1 year ago

Another visual that probably arises from the CEDCIT. Note how it only appears on single characters, and the Chinese reading of 間 and 多 is omitted. The grey box extends infinitely when scrolled down. Issue appears regardless of using the light or dark dictionary theme. PS: A Ctrl+F/Cmd+F find feature would be greatly appreciated, though I understand that the ttu reader does not support this natively. IMG_0047 IMG_0046 IMG_0045 IMG_0044