mathias-brandewinder / CNTK.FSharp

MIT License
67 stars 9 forks source link

sequential version of logistic example created #5

Closed AndreiDegtiarev closed 6 years ago

AndreiDegtiarev commented 6 years ago

Could you please take a look and suggest improvements

mathias-brandewinder commented 6 years ago

Looks pretty good, thank you! I'll take a closer look and merge a bit later :) Do you have feedback on the approach I took for Sequential models?

AndreiDegtiarev commented 6 years ago

Your approach seems to be quite functional and understandable especially in comparison to c# way. :-)

mathias-brandewinder commented 6 years ago

Merged - thank you! I am going to make some small changes, mostly my formatting OCD :) I am thinking that, since you went the route of creating a data file, I might also skip the intermediate step of creating batches, and do a straight sequence of rows / append to file.