Update bash-completion sourcing

mathiasbynens / dotfiles

:wrench: .files, including ~/.macos — sensible hacker defaults for macOS

https://mths.be/dotfiles

MIT License

30.04k stars 8.75k forks source link

Update bash-completion sourcing #864

Closed jeffbyrnes closed 5 years ago

jeffbyrnes commented 5 years ago

The previous sourcing is replaced with what the current “caveats” specify (see brew info bash-completion@2)

And, thanks to Homebrew/homebrew-core#36254, any bash-completions meant for bash-completion v1 are now included, thanks to the env var.

jeffbyrnes commented 5 years ago

@mathiasbynens bumping a bit; best to be sure to keep things squared up with what bash-completion2 tells us to do.

Xuhao commented 5 years ago

this PR resolve my problem 👍

AndrewSouthpaw commented 5 years ago

Great work @jeffbyrnes. It's exactly what was needed to fix the issues on my clean install. I hope the PR gets merged soon, it wasn't obvious what was the issue and took some time to reach this PR.

mathiasbynens commented 5 years ago

Thanks!