search

mathiasbynens / dotfiles

:wrench: .files, including ~/.macos — sensible hacker defaults for macOS
https://mths.be/dotfiles
MIT License
30.22k stars 8.74k forks source link

Per shellcheck, fgrep is deprecated #893

Closed jeffbyrnes closed 3 years ago

jeffbyrnes commented 5 years ago

Use grep -F instead.

Small thing, but shellcheck is pretty good about these things.

chendushek commented 5 years ago

That turned my screen gray and there’s an arrow up and down I can move around. That’s about it

jeffbyrnes commented 5 years ago

@chendushek I have no idea how that would happen; grep shouldn’t change your screen in any way at all. This change simply drops a deprecated binary in favor of the still-maintained one, adding a flag so the behavior is the same.

What happens if you run the previous version of this script? The effect should be the same, good or bad.

jeffbyrnes commented 3 years ago

@mathiasbynens this has been open for over a year, so I get the sense you’ve no intention of ever merging it 🙂 Totally cool.

I’m closing it to reduce a bit of clutter. Feel free to re-open & merge it if you want it!