Add the generated patterns to the repo

mathiasbynens / emoji-regex

A regular expression to match all Emoji-only symbols as per the Unicode Standard.

https://mths.be/emoji-regex

MIT License

1.73k stars 174 forks source link

Closed toolmantim closed 7 years ago

toolmantim commented 7 years ago

This adds the generated patterns to the repo, so their effect/change can be seen in compares/pull-requests (which prevent issues such as #24).

This also allows people to look up the tag in GitHub can see the pattern they're using, which might help debugging, and contribution.

This PR:

Adds the index.js, text.js and es2015 versions
Updates the npm scripts in package.json so they make sense with this new setup (you need to manually invoke npm run build-patterns to update the libs)

mathiasbynens commented 7 years ago

If we’re gonna check in the generated files, we should do so for the non-ES2015 versions too.

toolmantim commented 7 years ago

Oh, I see! I didn't see those, because I was only using the es2015 versions.

I'll update this PR, as it doesn't make sense without those too.

toolmantim commented 7 years ago

@mathiasbynens I've updated the PR! Let me know if that looks good, or you think anything needs changing.

toolmantim commented 7 years ago

@mathiasbynens thanks for the review! I've just made those changes.

toolmantim commented 7 years ago

@mathiasbynens this is ready for a re-review plz 🔍

mathiasbynens commented 7 years ago

Thanks, @toolmantim!