search

mathiasbynens / jquery-placeholder

A jQuery plugin that enables HTML5 placeholder behavior for browsers that aren’t trying hard enough yet
https://mths.be/placeholder
MIT License
3.98k stars 1.34k forks source link

Add support for AMD #199

Closed mattdrose closed 9 years ago

mattdrose commented 10 years ago

Added ability to load jquery-placeholder as a module using module loaders like RequireJS

kashifshamaz21 commented 10 years ago

+1 for this important addition, module loaders are an essence in modern js world.

amerikan commented 9 years ago

For ref: http://stackoverflow.com/a/11890239

amerikan commented 9 years ago

Please rebase so I can merge. Thanks.

amerikan commented 9 years ago

@mattdrose ping

mattdrose commented 9 years ago

When I added this to my fork, I tagged it (as 2.0.8... probably not the smartest) so that I could use it as a vendor. I have a number of projects (some in production), using this tag of my fork right now. Do you know how I can rebase it without squashing my tag on my forks commit?

williamboman commented 9 years ago

Do you want me to PR my branch? Not sure if I did things correctly, never dealt with front-end AMD.

mattdrose commented 9 years ago

It's okay. I just made a new pull request on a different branch. Thanks. See #233

If anyone knows a way I could have done this differently, I'd love the ghub tut :P