Initial attempt to fix Issue #17: "remove differences between `jsesc(data, { json: true })` and `JSON.stringify(data)"

mathiasbynens / jsesc

Given some data, jsesc returns the shortest possible stringified & ASCII-safe representation of that data.

https://mths.be/jsesc

MIT License

716 stars 53 forks source link

Initial attempt to fix Issue #17: "remove differences between `jsesc(data, { json: true })` and `JSON.stringify(data)" #18

Closed sonneveld closed 10 years ago

coveralls commented 10 years ago

Coverage increased (+0.09%) when pulling 806d2528ce6bee9f68af33e561ea7496b10de0f9 on sonneveld:issue17 into a4368cc02063500fedd3fbae99c8042a086a4e8b on mathiasbynens:master.

mathiasbynens commented 10 years ago

LGTM with those few comments addressed. Could you squash your commits once you’re finished? Thanks!

sonneveld commented 10 years ago

Thanks for the comments! I'll make those changes when I have a chance tomorrow.

mathiasbynens commented 10 years ago

@sonneveld Any updates on this? If you don’t have time to update your patch just let me know so that I can commit something myself.

sonneveld commented 10 years ago

Sorry. I have been putting it off! I should have time today to make those changes. If not I'll let you know.

sonneveld commented 10 years ago

Made the requested changes. Hopefully should be okay.

mathiasbynens commented 10 years ago

Merged in fb76b464a61cfa1a596a6bb850e92b8f10358cc9. Thanks!