search

mathiasbynens / punycode.js

A robust Punycode converter that fully complies to RFC 3492 and RFC 5891.
https://mths.be/punycode
MIT License
1.6k stars 159 forks source link

The prepublish script changes the export signature, mismatch to @types/punycode #112

Open retorquere opened 4 years ago

retorquere commented 4 years ago

The prepublish script changes the export signature, and in the npm-published package this new export signature makes it mismatch the type declaration in @types/punycode for typescript.

doggy8088 commented 3 years ago

I think the @types/punycode is for Node.js' built-in and deprecated punycode module. This will be deprecated since v7.0.0. (coming soon)

I'd like to suggest @bestiejs or @mathiasbynens include it's own TypeScript Declaration File within this package.